This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
fix: credential secrets: avoid race condition when prompting user (#2410) #2422
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #2410
There is a race condition that occurs only when deploying an acorn to the SaaS that defines a credential secret. The user will be prompted to enter credentials multiple times because the app keeps changing upstream. If we wait for a little bit (until all containers are marked as Defined), the race condition doesn't occur, and the user is only prompted once.
I also tested this with Acornfiles that only define this secret and a nested acorn, as well as an Acornfile that defines just the secret and nothing else, and it still works just fine.
Checklist
This is a title (#1216)
. Here's an example