Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade action to use node 16 #418

Closed
wants to merge 2 commits into from
Closed

Upgrade action to use node 16 #418

wants to merge 2 commits into from

Conversation

gateixeira
Copy link

What this PR does / Why we need it

Node 12 is being deprecated in GitHub Actions. This PR updates action.yml to use Node 16

Which issue(s) this PR fixes

Upgrades node version runner to 16

Fixes #413

@DestroyerAlpha
Copy link

Any blockers in updating this?

@gateixeira
Copy link
Author

@micnncim any chance you can review this? Thank you.

@micnncim micnncim added the release/minor Indicates minor update to action-release-label label Jan 7, 2023
@bflad
Copy link

bflad commented May 19, 2023

Hi @gateixeira 👋 I'm not a maintainer of this repository, however I did want to mention that the maintainers may also need the testing updated as well to fully resolve this, such as the testing currently being pinned to NodeJS 12 here:

@gateixeira
Copy link
Author

Thank you for the heads up @bflad!

I will add the change.

@h3llrais3r
Copy link

Any change to get this released soon? Would be great to get rid of the node12 deprecation warnings.

@gateixeira gateixeira closed this by deleting the head repository Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/minor Indicates minor update to action-release-label size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Node 12 to Node 16
5 participants