Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add limitations to runnersets + reorder #1285

Merged
merged 8 commits into from
Apr 3, 2022
Merged

docs: add limitations to runnersets + reorder #1285

merged 8 commits into from
Apr 3, 2022

Conversation

toast-gear
Copy link
Collaborator

@toast-gear toast-gear commented Mar 30, 2022 •
edited
Loading

Changes

  • Added PVC / PV build up limitation
  • Moved persistent runners further up as it's a runner mode and so should be group with the kinds and it has major implications for RunnerSets

@toast-gear toast-gear requested a review from mumoshu March 31, 2022 12:42
mumoshu
mumoshu approved these changes Apr 3, 2022
View reviewed changes
Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot for your continued effort on improving our documentation 🙇

@mumoshu mumoshu merged commit 85dea9b into master Apr 3, 2022
@mumoshu mumoshu deleted the docs/runnersets branch April 3, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumoshu mumoshu mumoshu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@toast-gear @mumoshu