Use -trimpath and ldflags -s -w build flags
#1880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumoshu
reviewed
Sep 29, 2022
| @@ -30,14 +30,14 @@ ARG TARGETPLATFORM TARGETOS TARGETARCH TARGETVARIANT VERSION=dev | |||
| # to avoid https://github.com/moby/buildkit/issues/2334 | |||
| # We can use docker layer cache so the build is fast enogh anyway | |||
| # We also use per-platform GOCACHE for the same reason. | |||
| env GOCACHE /build/${TARGETPLATFORM}/root/.cache/go-build | |||
There was a problem hiding this comment.
OMG! How did it ever work with lower-case?!
There was a problem hiding this comment.
Docker tries to interpret the first word as instruction unless it's bounded in between here doc. So it will work but not the best practice
There was a problem hiding this comment.
Good to know! Thanks a lot for the explanation
mumoshu
approved these changes
Sep 29, 2022
|
Yay
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use build flags
-trimpathand ldflags-s -wto generate slim binaries, More here and hereBefore
After (~48% downsize)