Add rootless runner to the Makefile and improve target platform handling. #2005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumoshu
reviewed
Nov 26, 2022
| @@ -44,7 +56,6 @@ docker-build-ubuntu: | |||
| ${DOCKER} build \ | |||
| --build-arg TARGETPLATFORM=${TARGETPLATFORM} \ | |||
| --build-arg RUNNER_VERSION=${RUNNER_VERSION} \ | |||
| --build-arg RUNNER_CONTAINER_HOOKS_VERSION=${RUNNER_CONTAINER_HOOKS_VERSION} \ | |||
There was a problem hiding this comment.
@toast-gear I think we can safely remove this arg for the rootless dind runner as the runner container hooks are installed only on the non-dind runner image.
mumoshu
reviewed
Nov 26, 2022
mumoshu
reviewed
Nov 26, 2022
mumoshu
reviewed
Nov 26, 2022
mumoshu
reviewed
Nov 26, 2022
|
@isarkis Hey! Thanks for your patience. We've recently updated our dockerfiles to work also on M2 mac. I've all those works from our main branch into your pull request so it ended up containing changes only for the makefile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1993