Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove caveat from useRunnerGroupsVisibility #2034

Merged
merged 1 commit into from
Nov 26, 2022
Merged

Conversation

toast-gear
Copy link
Collaborator

@toast-gear toast-gear commented Nov 23, 2022

This cavaet isn't really true anymore since GitHub added the visibility parameter, we had this warning because previously we had to make a bunch of API calls to figure it out.

Compare with whitespace changes hidden

@toast-gear toast-gear marked this pull request as ready for review November 23, 2022 17:26
Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks a lot for the fix ☺️

@mumoshu mumoshu merged commit cc15ff0 into master Nov 26, 2022
@mumoshu mumoshu deleted the docs/cleanup branch November 26, 2022 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants