Add CR and CRB to the helm chart #2504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
totogtr
requested review from
mumoshu,
toast-gear,
a team and
nikola-jokic
as code owners
Link-
added
needs triage
mumoshu
reviewed
Apr 21, 2023
charts/actions-runner-controller/templates/actionsmetrics.role.yaml
Outdated
Show resolved
Hide resolved
mumoshu
reviewed
Apr 21, 2023
charts/actions-runner-controller/templates/actionsmetrics.role_binding.yaml
Outdated
Show resolved
Hide resolved
mumoshu
reviewed
Apr 21, 2023
| @@ -5,7 +5,7 @@ metadata: | |||
| name: {{ include "actions-runner-controller-actions-metrics-server.fullname" . }} | |||
| namespace: {{ .Release.Namespace }} | |||
| labels: | |||
| {{- include "actions-runner-controller.labels" . | nindent 4 }} | |||
| {{- include "actions-runner-controller-actions-metrics-server.selectorLabels" . | nindent 4 }} | |||
|
Hey @mumoshu, thanks a lot for reviewing. Indeed the enable conditions were wrong and fixed by your suggestion, I must have done some bad copy pasting here sorry ! |
…he ServiceMonitor
….yaml Co-authored-by: Yusuke Kuoka <ykuoka@gmail.com>
…_binding.yaml Co-authored-by: Yusuke Kuoka <ykuoka@gmail.com>
mumoshu
added a commit
that referenced
this pull request
May 11, 2023
Sorry for the delayed release! This chart version is mainly for upgrading ARC to v0.27.4, along with a few fixes to the chart itself (#2504, #2498) Please also refer to https://github.com/actions/actions-runner-controller/releases/tag/v0.27.4 for more details about changes made in ARC v0.27.4.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #2212 , the ARC helm chart is missing ClusterRoleBinding and ClusterRole for the ActionsMetricsServer resulting on missing permissions.
This also fix the labels of the ActionsMetricsServer Service as it is selected by the ServiceMonitor with those labels.