feat(chart): refactor helm chart #3645
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norman-zon
force-pushed
the
helmchart-refactor
branch
12 times, most recently
from
ef1dd41
to
6bc2d54
Compare
To avoid having to completely define template.spec, in case the user
wanted to make significant changes to the runner pod, new values
extra{Args,Env,VolumeMounts...} are introduced.
This also makes the helm chart follow a more canonical layout than
before
norman-zon
force-pushed
the
helmchart-refactor
branch
from
6bc2d54
to
3aee4aa
Compare
norman-zon
requested review from
mumoshu,
toast-gear,
rentziass and
a team
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reactions and follow up discussion in #3216 seemed to signal users are interested in a design for the helm chart, where pod configuration is done using
extra...values, instead of thetemplate.specapproach.I understand the design decision for the current implementation, but wanted to provide an alternative.