fix: remove dockerd as args in runner controller #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumoshu
reviewed
Mar 31, 2021
| @@ -703,7 +703,6 @@ func (r *RunnerReconciler) newPod(runner v1alpha1.Runner) (corev1.Pod, error) { | |||
| pod.Spec.Containers = append(pod.Spec.Containers, corev1.Container{ | |||
| Name: "docker", | |||
| Image: r.DockerImage, | |||
| Args: []string{"dockerd"}, | |||
There was a problem hiding this comment.
Thanks! I'm wondering if removing this breaks dockerMTU handling at L733. Let me check
There was a problem hiding this comment.
Nevermind. This looks OK seeing
vs
With Args: []string{"dockerd"}, we go to the latter where default options that includes docker certs dirs are not set.
Without that we go to the former path where default options exists as before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #431
Succesfully tested on a with the default runner image. It enables creation of the necessary docker certificates.