Experimental support for ScheduledOverrides #515
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the initial version of ScheduledOverrides to HorizontalRunnerAutoscaler.
Daily/Weekly/Monthly/Yearly
MinReplicas
overriding should just work.Here's an example of a weekly override:
When there are two or more ScheduledOverrides, the earliest one that matched is activated.
Each ScheduledOverride can be recurring or one-time. If you have two or more ScheduledOverrides, only one of them should be one-time. And the one-time override should be the earliest item in the list to make sense.
Ref #484
Notes:
This fixes API/CRD changes made in the wrong place in #514.
Tests will be added in another commit. Logging improvements and additional observability in HRA.Status will also be added in yet another commit.