Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version of - Git for Windows #1611

Closed
5 tasks
ghost opened this issue Sep 17, 2020 · 6 comments
Closed
5 tasks

Update version of - Git for Windows #1611

ghost opened this issue Sep 17, 2020 · 6 comments

Comments

@ghost
Copy link

ghost commented Sep 17, 2020

Tool information

Area for Triage: Git

Question, Bug, or Feature?: Feature

Virtual environments affected

  • macOS 10.15
  • Ubuntu 16.04 LTS
  • Ubuntu 18.04 LTS
  • Ubuntu 20.04 LTS
  • Windows Server 2016 R2
  • [ x ] Windows Server 2019

Can this tool be installed during the build?
No

Tool installation time in runtime
1 minute

Are you willing to submit a PR?
Yes

@maxim-lobanov
Copy link
Contributor

Hello @leemacatangay , I see you also requested installation of GVFS in #1612. Could you please share some context around these tools?
As I understand, GVFS from #1612 is a separate tool but what is this one Git-2.28.0.vfs.0.0-64-bit.exe? Currently, we install Git For Windows from https://github.com/git-for-windows/git. Is it plugin or replacement?

cc: @dscho

@dscho
Copy link
Contributor

dscho commented Sep 24, 2020

That would be the replacement installer, but it's not enough for GVFS... there is another component: https://github.com/microsoft/vfsforgit/releases (which includes the VFS for Git-specific Git fork AFAIR).

Taking a step back, I'm not actually sure that it makes sense to include VFS for Git; it requires a kernel driver...

@ghost
Copy link
Author

ghost commented Sep 24, 2020 via email

@AlenaSviridenko
Copy link
Contributor

Hi @leemacatangay,
unfortunately, we cannot add these tools to the image, because Git for Windows is a commonly used tool and its replacement can lead to an unpredictable impact.
Current Git for Windows https://github.com/git-for-windows/git doesn't have a support for GVFS, as I understand. @dscho please, correct me if I am wrong.

I am closing this issue, please, feel free to open a new one for any other questions.
Thanks!

@dscho
Copy link
Contributor

dscho commented Sep 25, 2020

I agree that it makes more sense to support regular Git out of the box, and not force VFS for Git on every Azure Pipeline/GitHub Action user.

The best way to use VFS for Git in CI, from my perspective, is to set up your own VMs and install build agents on them.

@ghost
Copy link
Author

ghost commented Sep 25, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants