Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose ghcup binary to PATH on windows #4264

Merged
merged 10 commits into from
Dec 10, 2021
Merged

Expose ghcup binary to PATH on windows #4264

merged 10 commits into from
Dec 10, 2021

Commits on Oct 12, 2021

  1. Expose ghcup binary to PATH on windows 

    The bootstrap-haskell.ps1 script uses
'[System.EnvironmentVariableTarget]::User' instead of
'[System.EnvironmentVariableTarget]::Machine', so it appears
ghcup env vars and PATH update never make it. Do these manually
for now.
    @hasufell
    hasufell committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    8b1ede4 View commit details
    Browse the repository at this point in the history

  2. Set CABAL_DIR and make sure config is adjusted 

    The config adjustment usually includes adding msys2 directories,
so cabal can find `pkg-config` and libraries, e.g.:

+ C: \ghcup\msys64\mingw64\bin
+ extra-include-dirs: C:\ghcup\msys64\mingw64\include
+ extra-lib-dirs: C:\ghcup\msys64\mingw64\lib
- extra-prog-path: C:\cabal\bin
+ extra-prog-path: C:\ghcup\bin,
    @hasufell
    hasufell committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    7a0460b View commit details
    Browse the repository at this point in the history

  3. Expose cabal dir to PATH as well

    @hasufell
    hasufell committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    11f1eb0 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2021

  1. Use Set-SystemVariable

    @hasufell
    hasufell committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    193d22b View commit details
    Browse the repository at this point in the history

  2. Fix tests

    @hasufell
    hasufell committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    2eb265e View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2021

  1. Use hardcoded cabal dir

    @hasufell
    hasufell committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    a99dc64 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2021

  1. Fix bootstrap-haskell

    @hasufell
    hasufell committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    e73f4a7 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2021

  1. Move test after installation

    @hasufell
    hasufell committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    a0fae3f View commit details
    Browse the repository at this point in the history

  2. Print ghcup installation message

    @hasufell
    hasufell committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    4a76bc2 View commit details
    Browse the repository at this point in the history

  3. Don't adjust cabal.config (to include mingw paths) 

    This may break setups.
    @hasufell
    hasufell committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    354a537 View commit details
    Browse the repository at this point in the history