Add setting for always-auth #48
Conversation
DavidJFelix
commented
Aug 29, 2019
DavidJFelix
commented
- https://docs.npmjs.com/misc/config#always-auth
- Allow private repos for stuff like artifactory to work
- https://docs.npmjs.com/misc/config#always-auth - Allow private repos for stuff like artifactory to work
|
A little background: JFrog Artifactory (Cloud) wants always-auth=true for both yarn and npm for private repos. |
There was a problem hiding this comment.
This looks like a good change to me - would you mind adding a test in https://github.com/actions/setup-node/blob/master/__tests__/authutil.test.ts? Also, I'm pretty sure this will break some existing tests, could you update those as well?
| @@ -2,6 +2,9 @@ name: 'Setup Node.js environment' | |||
| description: 'Setup a Node.js environment and add it to the PATH, additionally providing proxy support' | |||
| author: 'GitHub' | |||
| inputs: | |||
| always-auth: | |||
There was a problem hiding this comment.
Nit - this should go after scope in the parameter ordering. That way its grouped with the other auth parameters and comes after registry-url which is required in all auth cases.
There was a problem hiding this comment.
Counter nit: Opinion: At the top it leaves the map in alphabetical order.
|
I'll make changes as requested. Give me a bit to execute them. I left some justifications in case you're feeling like being persuaded by an internet stranger. |
|
You should see the changes as requested in the most recent commit. Let me know if you want me to rebase them. |
bump connector version
