Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache: Delete temporary archive after upload #792

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

rcowsill
Copy link
Contributor

@rcowsill rcowsill commented May 5, 2021

This is to avoid filling the SSD while saving multiple large caches

Fixes #791

@rcowsill rcowsill marked this pull request as ready for review May 6, 2021 13:14
@rcowsill rcowsill requested a review from a team May 6, 2021 13:14
@rcowsill rcowsill changed the title Delete temporary archive after cache upload Cache: Delete temporary archive after upload May 6, 2021
This is to avoid filling the SSD while saving multiple large caches
Copy link
Contributor

@konradpabjan konradpabjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the investigation and the PR!

@rcowsill
Copy link
Contributor Author

Do I need to do anything to address the toolkit-audit failure? I haven't changed the dependencies so I expect it to pass after the merge.

@thboop
Copy link
Collaborator

thboop commented Jun 28, 2021

Do I need to do anything to address the toolkit-audit failure? I haven't changed the dependencies so I expect it to pass after the merge.

No, thanks for bringing it up but we will take care of it! Feel free to ignore it on this PR.

@konradpabjan konradpabjan merged commit 4564768 into actions:main Jun 28, 2021
@rcowsill rcowsill deleted the post-save-cleanup branch June 30, 2021 14:24
Copy link

@nodoubtz nodoubtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up temporary archive file at the end of saveCache
4 participants