-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added OIDC client functionality in core package #887
Added OIDC client functionality in core package #887
Conversation
packages/core/package.json
Outdated
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@actions/core", | |||
"version": "1.5.0", | |||
"version": "1.5.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets go to 1.6.0.
Please also update the https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md file with this change under the version 1.6.0
Excited for this PR to land 🚀 . Left some minor comments on process, @luketomlinson is going to review the contents of the pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor things, but no show-stoppers. Good work @souravchanduka!
@souravchanduka, @TingluoHuang is going to coordinate when this should get merged/released. |
I am going to merge this PR to a feature branch, and create follow up PR to react to the latest update around OIDC on the service side. |
In order to get the temporary credentials for accessing cloud resources, we need to get the ID Token from the action service. This ID Token will be used by login actions of different cloud providers. Since the code to fetch the ID Token will be same for all the login actions, we can use this functionality. All the login actions would import this package and get the ID token for further use.