Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize pipeline related bussiness logic #2586

Merged
merged 3 commits into from
Sep 5, 2024
Merged

optimize pipeline related bussiness logic #2586

merged 3 commits into from
Sep 5, 2024

Conversation

winfredLIN
Copy link
Collaborator

@winfredLIN winfredLIN commented Sep 5, 2024 •
edited
Loading

关联的 issue

#2579

描述你的变更

  1. 当删除数据源时，会检查流水线节点是否有关联该数据源，若关联则无法删除
  2. 优化了流水线节点的表，用instance id 替代instance name
  3. 在删除流水线的时候，使用project id进行筛选

确认项（pr提交后操作）

Tip

请在指定复审人之前，确认并完成以下事项，完成后✅

  • 我已完成自测
  • 我已在关联的issue里补充了实现方案
  • 我已在关联的issue里补充了测试影响面
  • 我已确认了变更的兼容性，如果不兼容则在issue里标记 not_compatible
  • 我已确认了是否要更新文档，如果要更新则在issue里标记 need_update_doc

@winfredLIN winfredLIN self-assigned this Sep 5, 2024
@winfredLIN winfredLIN added the not_compatible not compatible old version label Sep 5, 2024
@LordofAvernus LordofAvernus merged commit 10c2259 into main Sep 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordofAvernus LordofAvernus LordofAvernus approved these changes

@ColdWaterLW ColdWaterLW Awaiting requested review from ColdWaterLW

Assignees

@winfredLIN winfredLIN

Labels
not_compatible not compatible old version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@winfredLIN @LordofAvernus