Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: github_token and github_url optional #134

Merged
merged 1 commit into from
Jun 28, 2022
Merged

fix: github_token and github_url optional #134

merged 1 commit into from
Jun 28, 2022

Conversation

SevereCloud
Copy link
Contributor

image

@ZPascal
Copy link
Collaborator

ZPascal commented Jun 28, 2022

Hi Daniil, could you please describe detailed the case. A screenshot from VSCode is not the best description, and in general the parameters are marked as required and using default values.

@SevereCloud
Copy link
Contributor Author

the parameters are marked as required and using default values

A parameter cannot be required and have a default value at the same time

@ZPascal
Copy link
Collaborator

ZPascal commented Jun 28, 2022

the parameters are marked as required and using default values

A parameter cannot be required and have a default value at the same time

Hi @SevereCloud, that's valid.

@ZPascal ZPascal self-requested a review June 28, 2022 12:17
ZPascal
ZPascal approved these changes Jun 28, 2022
View reviewed changes
Copy link
Collaborator

@ZPascal ZPascal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZPascal ZPascal merged commit 9a46ba8 into ad-m:master Jun 28, 2022
@SevereCloud SevereCloud deleted the patch-1 branch June 28, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZPascal ZPascal ZPascal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SevereCloud @ZPascal