Skip to content
This repository has been archived by the owner on Jun 28, 2021. It is now read-only.

Implement raw option #88

Merged
merged 2 commits into from
Jul 28, 2016
Merged

Implement raw option #88

merged 2 commits into from
Jul 28, 2016

Conversation

AGhost-7
Copy link
Contributor

This adds a raw option which will make each csv row parsed into an object containing two properties:

  • raw: a string which is the original data that was parsed.
  • row: an array or object (depending on other options used) which is the parsed row.

Fixes issue #85

@tejasmanohar
Copy link

tejasmanohar commented Apr 27, 2016

I'd prefer parsed to row, but overall, +1 for this PR. Super useful for debugging.

cc @wdavidw

@wdavidw
Copy link
Member

wdavidw commented Apr 27, 2016

Thanks, why is rowBuf in line 163 and 167 and not just after line 160 ?

@AGhost-7
Copy link
Contributor Author

@wdavidw For rawBuf I only clear it if I'm done with it. For line 163 and 167 it exits early so I clear it there, otherwise it gets cleared at line 183.

@AGhost-7
Copy link
Contributor Author

@wdavidw Is there something wrong with the PR? At work this would be really useful for debugging data imports.

@wdavidw
Copy link
Member

wdavidw commented May 24, 2016

One thing, line 234, there is a reference to @raw which i dont see anywhere else.

@wdavidw wdavidw merged commit b3d696c into adaltas:master Jul 28, 2016
wdavidw added a commit that referenced this pull request Jul 28, 2016
@wdavidw wdavidw mentioned this pull request Dec 6, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants