Removed the unused code to write entries in Zip Headers #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more a suggestion than a request.
As I found out with #210 there is some unused code.
The unused code appears because the writing of zip files is done from the
Writers.Zipnamespace, and the reading is done inCommon.Zip.Headers.I guess there could be a consolidation of the two, such that the same classes represents the same entries for both readers and writers. If this is a better approach, much of the code in
ZipWriter.cscan be moved into theCommon.Zip.Headersclasses, but there are edge cases, as the writers need to store some temporary information in the structures (can be solved by a writer-specific class deriving from the other entry perhaps).