Add fast ExtractToDirectoryAsync extension method on IArchive
#750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…very fast compared to `WriteToDirectory`.
adamhathcock
requested changes
Jul 19, 2023
|
I've removed the Task aspect in the implementation. It still feels a bit odd to me since it has its own progress reporting and doesn't fire the progress events on |
adamhathcock
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #728 (and I believe some other issues), the
IArchive.WriteToDirectory(...)extension method can be very slow for.7zfiles. This extension utilizedIArchive.ExtractAllEntries()andIReaderso is fast for .7z files.Being async has nothing to do with the performance, rather, it's because I use this extension method from an async method and need it to perform the long-running work asynchronously. Ideally
IArchive.ExtractAllEntries()andIReader.WriteEntryTo(Stream)would be async as well and then the whole Task.Run wouldn't be needed and then it would make more sense to be async.It currently doesn't support
ExtractionOptionsor reporting progress throughIArchive's events (although it does report progress through a callback). But, it works great as-is for my use case, which I suspect is pretty common, and I wanted to share.