Skip to content

Commit

Permalink
enable EndpointsFailOpen by default (kubernetes-sigs#3078)
Browse files Browse the repository at this point in the history
  • Loading branch information
kishorj authored and Timothy-Dougherty committed Nov 9, 2023
1 parent 8256265 commit 2ebe47e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions docs/deploy/configurations.md
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,8 @@ They are a set of kye=value pairs that describe AWS load balance controller feat
| ListenerRulesTagging | string | true | Enable or disable tagging AWS load balancer listeners and rules |
| WeightedTargetGroups | string | true | Enable or disable weighted target groups |
| ServiceTypeLoadBalancerOnly | string | false | If enabled, controller will be limited to reconciling service of type `LoadBalancer`|
| EndpointsFailOpen | string | false | Enable or disable allowing endpoints with `ready:unknown` state in the target groups. |
| EndpointsFailOpen | string | true | Enable or disable allowing endpoints with `ready:unknown` state in the target groups. |
| EnableServiceController | string | true | Toggles support for `Service` type resources. |
| EnableIPTargetType | string | true | Used to toggle support for target-type `ip` across `Ingress` and `Service` type resources. |
| SubnetsClusterTagCheck | string | true | Enable or disable the check for `kubernetes.io/cluster/${cluster-name}` during subnet auto-discovery |
| NLBHealthCheckAdvancedConfiguration | string | true | Enable or disable advanced health check configuration for NLB, for example health check timeout |
| NLBHealthCheckAdvancedConfiguration | string | true | Enable or disable advanced health check configuration for NLB, for example health check timeout |
2 changes: 1 addition & 1 deletion pkg/config/feature_gates.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ func NewFeatureGates() FeatureGates {
ListenerRulesTagging: true,
WeightedTargetGroups: true,
ServiceTypeLoadBalancerOnly: false,
EndpointsFailOpen: false,
EndpointsFailOpen: true,
EnableServiceController: true,
EnableIPTargetType: true,
SubnetsClusterTagCheck: true,
Expand Down

0 comments on commit 2ebe47e

Please sign in to comment.