fix nullability of configure env delegate

adamralph · Feb 20, 2022 · 6f3a396 · 6f3a396
1 parent 0884ff2
commit 6f3a396
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/SimpleExec/Command.cs b/SimpleExec/Command.cs
@@ -14,7 +14,7 @@ namespace SimpleExec
     /// </summary>
     public static class Command
     {
-        private static readonly Action<IDictionary<string, string>> defaultAction = _ => { };
+        private static readonly Action<IDictionary<string, string?>> defaultAction = _ => { };
         private static readonly string defaultEchoPrefix = Assembly.GetEntryAssembly()?.GetName().Name ?? "SimpleExec";
 
         /// <summary>
@@ -49,7 +49,7 @@ public static void Run(
             string? windowsName = null,
             string? windowsArgs = null,
             string? echoPrefix = null,
-            Action<IDictionary<string, string>>? configureEnvironment = null,
+            Action<IDictionary<string, string?>>? configureEnvironment = null,
             bool createNoWindow = false,
             Func<int, bool>? handleExitCode = null,
             CancellationToken cancellationToken = default)
@@ -107,7 +107,7 @@ public static async Task RunAsync(
             string? windowsName = null,
             string? windowsArgs = null,
             string? echoPrefix = null,
-            Action<IDictionary<string, string>>? configureEnvironment = null,
+            Action<IDictionary<string, string?>>? configureEnvironment = null,
             bool createNoWindow = false,
             Func<int, bool>? handleExitCode = null,
             CancellationToken cancellationToken = default)
@@ -162,7 +162,7 @@ public static async Task RunAsync(
             string workingDirectory = "",
             string? windowsName = null,
             string? windowsArgs = null,
-            Action<IDictionary<string, string>>? configureEnvironment = null,
+            Action<IDictionary<string, string?>>? configureEnvironment = null,
             Encoding? encoding = null,
             Func<int, bool>? handleExitCode = null,
             string? standardInput = null,

diff --git a/SimpleExec/ProcessStartInfo.cs b/SimpleExec/ProcessStartInfo.cs
@@ -11,7 +11,7 @@ public static System.Diagnostics.ProcessStartInfo Create(
             string args,
             string workingDirectory,
             bool redirectStandardStreams,
-            Action<IDictionary<string, string>> configureEnvironment,
+            Action<IDictionary<string, string?>> configureEnvironment,
             bool createNoWindow,
             Encoding? encoding = null)
         {

diff --git a/SimpleExec/PublicAPI.Shipped.txt b/SimpleExec/PublicAPI.Shipped.txt
@@ -9,6 +9,6 @@ SimpleExec.ExitCodeReadException
 SimpleExec.ExitCodeReadException.ExitCodeReadException(int exitCode, string! standardOutput, string! standardError) -> void
 SimpleExec.ExitCodeReadException.StandardError.get -> string!
 SimpleExec.ExitCodeReadException.StandardOutput.get -> string!
-static SimpleExec.Command.ReadAsync(string! name, string! args = "", string! workingDirectory = "", string? windowsName = null, string? windowsArgs = null, System.Action<System.Collections.Generic.IDictionary<string!, string!>!>? configureEnvironment = null, System.Text.Encoding? encoding = null, System.Func<int, bool>? handleExitCode = null, string? standardInput = null, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.Task<(string! StandardOutput, string! StandardError)>!
-static SimpleExec.Command.Run(string! name, string! args = "", string! workingDirectory = "", bool noEcho = false, string? windowsName = null, string? windowsArgs = null, string? echoPrefix = null, System.Action<System.Collections.Generic.IDictionary<string!, string!>!>? configureEnvironment = null, bool createNoWindow = false, System.Func<int, bool>? handleExitCode = null, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> void
-static SimpleExec.Command.RunAsync(string! name, string! args = "", string! workingDirectory = "", bool noEcho = false, string? windowsName = null, string? windowsArgs = null, string? echoPrefix = null, System.Action<System.Collections.Generic.IDictionary<string!, string!>!>? configureEnvironment = null, bool createNoWindow = false, System.Func<int, bool>? handleExitCode = null, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.Task!
+static SimpleExec.Command.ReadAsync(string! name, string! args = "", string! workingDirectory = "", string? windowsName = null, string? windowsArgs = null, System.Action<System.Collections.Generic.IDictionary<string!, string?>!>? configureEnvironment = null, System.Text.Encoding? encoding = null, System.Func<int, bool>? handleExitCode = null, string? standardInput = null, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.Task<(string! StandardOutput, string! StandardError)>!
+static SimpleExec.Command.Run(string! name, string! args = "", string! workingDirectory = "", bool noEcho = false, string? windowsName = null, string? windowsArgs = null, string? echoPrefix = null, System.Action<System.Collections.Generic.IDictionary<string!, string?>!>? configureEnvironment = null, bool createNoWindow = false, System.Func<int, bool>? handleExitCode = null, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> void
+static SimpleExec.Command.RunAsync(string! name, string! args = "", string! workingDirectory = "", bool noEcho = false, string? windowsName = null, string? windowsArgs = null, string? echoPrefix = null, System.Action<System.Collections.Generic.IDictionary<string!, string?>!>? configureEnvironment = null, bool createNoWindow = false, System.Func<int, bool>? handleExitCode = null, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.Task!