This repository has been archived by the owner on Jul 7, 2020. It is now read-only.
Cleanup of error handling in AbstractOutputWriter. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ERROR is for error conditions. WARN is for warnings. When in doubt use ERROR over WARN.
…ecture. Use the lazy loading mechanism when loading the executable targets. Because we do not want to load the yammer metrics for all executable classes, then we must use a lazy loading mechanism.
…e.prepare release v4.1.2
…e.prepare for next development iteration
to the beginning of the local-stack.sh script.
…led bundles not packets.
be run outside the context of a hydra job. Moving class from /test to /main in order to make it possible to deploy in executable jar.
does not belong on a page, then move it to the next page only if the key does not already exist in the next page. If the key already exists in the next page, then do not move the (key, value) pair but delete the (key, value) pair. Minor change to logging output so it will emit position i of the key with respect to the original ordering of the keys.
…ompleted ops do not suck up any more CPU/IO than needed
…ent a job from being deleted. The default value is disabled. Renaming the method Spawn#deleteJob(String, String, Integer, boolean) to Spawn#deleteTask() so it will not be conflated with the actual job deletion method. Added @OverRide annotations where appropriate in Job class.
should have log level ERROR.
error is detected in any of the threads then record the error so that subsequent calls of writeLine(String, Bundle) will propagate the error to exit the job. Converted the fields 'stopped' and 'exiting' from AtomicBooleans to volatiles because no test-and-set operations are performed on these variables.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an error is detected in any of the threads then record the error so that subsequent calls of writeLine(String, Bundle) will propagate the error to exit the job. Converted the fields 'stopped' and 'exiting' from AtomicBooleans to volatiles because no test-and-set operations are performed on these variables.