fix minion death loop when a job directory is blown away but minion thin... #23
Conversation
…hings it's maybe running
|
I don't understand what effect this change has on the Minion behavior. In the original implementation if a job directory is blown away then 'success' would be set to false on line 2017. The 'success' variable has no effect other than to dictate what logging message is produced. With this patch 'succes' is set to true if the job directory is missing. What behavior does this change besides logging? |
|
well, let's call it a logging death loop then. pre-patch minion emits a constant stream of stack traces. |
|
It seems like a bad idea to patch an unwanted code action by eliminating the log messages but continuing to perform the action. |
|
it does more than that. it sets success to true when there are clearly no more directories to attempt to delete in vain. |
|
Is this a suitable alternative? #28. It does not enter the while() loop if the parent directory is missing. |
...gs it's maybe running