This repository has been archived by the owner on Jul 7, 2020. It is now read-only.
Dynamic loader implementation #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 12, 2014 10:40
…, then Class#forName(String) will not be able to find that class when called from a class that uses the default loader.
string ("") in 2nd column of the csv file to avoid the need
to type out duplicate JAR locations.
|
You can now specify the empty string for the second column if you don't want to type out the URL to the external jar on multiple rows: |
|
i have not tried this yet. is it in theory possible to extend PathElements and TreeData? can i do this through code alone or do i need to inject classmap spring files? |
|
I think it is possible to extend classes that are found in hydra. |
|
Merging this pull request. We can revise it later if it is inadequate. |
mspiegel
added a commit
that referenced
this pull request
Feb 27, 2014
Dynamic loader implementation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternate proposal for #24. Dynamic class loading is specified with the command-line option -Dhydra.loader=[URI to configuration]. The configuration file is a CSV formatted file. Each row must have either two columns or four columns.
A row with two columns has the format:
A row with four columns has the format:
I have tested the four column format by creating a jar that contained a class HelloWorld with a static main() method that prints out "Hello World". In my configuration file I specified:
By running on the command line the following command:
I was able to print out "hello world" instead of running a hydra task. Hooray for class injection.
I have not tested the two column version of this implementation. The Codec library is not designed to load classes from alternate class loaders. The same deficiancy applies to the original proposal #24. It is outside of scope to fix that bug. This proposal is only for executable classes and we can address the Codec issue at a later time.