This repository has been archived by the owner on Jul 7, 2020. It is now read-only.
Jiayang/gdpr #289
Merged
Jiayang/gdpr #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some recommendations here:
|
tedpearson
reviewed
Oct 25, 2018
| ScheduledThreadPoolExecutor executor = new ScheduledThreadPoolExecutor(1); | ||
| // upon JVM termination, wait for the tasks for up to 100ms before exiting the executor service | ||
| ScheduledExecutorService executorService = MoreExecutors.getExitingScheduledExecutorService(executor, 100, TimeUnit.MILLISECONDS); | ||
| executorService.scheduleWithFixedDelay(() -> { |
There was a problem hiding this comment.
My intellij inspections recommend using a method reference instead of a lambda here: this::postDecodeHelper
tedpearson
suggested changes
Oct 25, 2018
| @Override public void postDecode() { | ||
| if (refreshMinutes == 0) { | ||
| postDecodeHelper(); | ||
| } else { |
There was a problem hiding this comment.
I noticed a pretty serious issue here - in the case where refresh is enabled, we only call postDecodeHelper in the scheduled executor service. While it's true that we call it immediately, it's called asynchronously without blocking. We need to block here so that this value filter can't be used until the post decode step has occured at least once. Therefore, we should always call postDecodeHelper in this method, and change the scheduled executor to not refresh immediately.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.