Skip to content
This repository has been archived by the owner on Jul 7, 2020. It is now read-only.

mesh-based message queueing #53

Closed
wants to merge 7 commits into from
Closed

mesh-based message queueing #53

wants to merge 7 commits into from

Conversation

stewartoallen
Copy link
Contributor

No description provided.

minion/spawn comms need significant cleanup, doc and externalization
the abstraction should be completed in subsequent patches
fix first-time creation bug for queues
@abramsm
Copy link
Contributor

abramsm commented Mar 25, 2014

minor: can we use log.error vs e.printStackTrace?

in general this looks good to me. We'll need to run it through our test stack before merging into master.

@stewartoallen
Copy link
Contributor Author

of course. thanks.

On Mar 25, 2014, at 5:49 PM, Matt Abrams notifications@github.com wrote:

minor: can we use log.error vs e.printStackTrace?

in general this looks good to me. We'll need to run it through our test stack before merging into master.


Reply to this email directly or view it on GitHub.

@tea-dragon
Copy link
Contributor

Looks fine to me. I would rather be able to encapsulate the large if (system.property) blocks into implementation classes, but oh well. I tried resolving the merge conflicts a couple times but my merge skills are imperfect and i'm not entirely familiar with the code that has conflicts so I am giving up on doing that myself for now.

@tea-dragon
Copy link
Contributor

closing since the other PR is supposed to supercede this one.

@tea-dragon tea-dragon closed this Apr 1, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants