Skip to content
This repository has been archived by the owner on Jul 7, 2020. It is now read-only.

fix missing space in conditional in generated replication script #61

Merged
merged 1 commit into from
Apr 3, 2014
Merged

fix missing space in conditional in generated replication script #61

merged 1 commit into from
Apr 3, 2014

Conversation

stewartoallen
Copy link
Contributor

No description provided.

@stewartoallen
Copy link
Contributor Author

pretty simple one character fix. not clear how it was working before.

mspiegel added a commit that referenced this pull request Apr 3, 2014
@mspiegel
Merge pull request #61 from stewartoallen/at-pull-fix-replicate-script
c354ffd 
fix missing space in conditional in generated replication script
@mspiegel mspiegel merged commit c354ffd into addthis:master Apr 3, 2014
mspiegel pushed a commit that referenced this pull request Apr 7, 2014
Merging latest master into branch.
eca53f8 
commit c039597
Author: Michael Spiegel <spiegel@addthis.com>
Date:   Mon Apr 7 15:28:28 2014 -0400

    Addition of enforcer.fail property.

commit 40f73e4
Author: Michael Spiegel <spiegel@addthis.com>
Date:   Mon Apr 7 14:36:21 2014 -0400

    Increment bark dependency version.

commit cd612ee
Author: Michael Spiegel <spiegel@addthis.com>
Date:   Mon Apr 7 14:21:13 2014 -0400

    Increment meshy version dependency.

commit f818c62
Author: Michael Spiegel <spiegel@addthis.com>
Date:   Mon Apr 7 13:48:28 2014 -0400

    Increment bundle and muxy dependency versions.

commit ceb9433
Author: Michael Spiegel <spiegel@addthis.com>
Date:   Mon Apr 7 13:02:31 2014 -0400

    Increment basis and codec dependency versions.

commit 667c3ad
Merge: 53939f8 17fecc2
Author: mspiegel <michael.m.spiegel@gmail.com>
Date:   Fri Apr 4 14:10:00 2014 -0400

    Merge pull request #62 from stewartoallen/at-pull-proper-json-responses

    ensure properly formatted json responses

commit 17fecc2
Author: Stewart Allen <stewart@neuron.com>
Date:   Fri Apr 4 14:09:01 2014 -0400

    remove commented out lines

commit 53939f8
Merge: f361c66 9c74d90
Author: Matt Abrams <abramsm@gmail.com>
Date:   Fri Apr 4 10:25:04 2014 -0400

    Merge pull request #64 from erichees/spawn2-metrics

    add metrics endpoint to spawn2 servlet

commit f361c66
Merge: 0f2d952 148eab0
Author: mspiegel <michael.m.spiegel@gmail.com>
Date:   Thu Apr 3 16:23:20 2014 -0400

    Merge pull request #66 from erichees/dependencies

    Dependencies

commit 0f2d952
Merge: ebe73ff 31b89c0
Author: mspiegel <michael.m.spiegel@gmail.com>
Date:   Thu Apr 3 16:16:56 2014 -0400

    Merge pull request #65 from erichees/ui-improvements

    Ui improvements

commit 9c74d90
Author: hees <hees@addthis.com>
Date:   Wed Apr 2 14:35:40 2014 -0400

    add metrics endpoint to spawn2 servlet

    - fixed bug in MinionsDown Gauge

commit 148eab0
Author: hees <hees@addthis.com>
Date:   Wed Apr 2 14:54:32 2014 -0400

    add links to dependency view

commit 012c065
Author: hees <hees@addthis.com>
Date:   Mon Mar 31 15:49:32 2014 -0400

    addons to dependencies tab

    - use all connections instead of sinks
    - highlight current job in green

commit 0fc5973
Author: hees <hees@addthis.com>
Date:   Mon Mar 31 13:08:48 2014 -0400

    make all dependency text render rightside-up

commit 31b89c0
Author: hees <hees@addthis.com>
Date:   Thu Apr 3 14:52:29 2014 -0400

    adjust table header width on jobs-list redraw

commit 0364bfe
Author: hees <hees@addthis.com>
Date:   Mon Mar 31 17:38:53 2014 -0400

    added enabled only filter

commit 14bfc54
Author: hees <hees@addthis.com>
Date:   Mon Mar 31 12:04:40 2014 -0400

    add user name to macro save

commit ebe73ff
Author: Michael Spiegel <spiegel@addthis.com>
Date:   Thu Apr 3 13:56:23 2014 -0400

    Upgrade to bark 2.1.2.

    This version of bark has a bugfix. The change is to strip
    the trailing "/" character from the zookeeper path. The
    underlying Zookeeper client will throw an exception if the
    path ends in a slash.

commit b600625
Author: Stewart Allen <stewart@neuron.com>
Date:   Thu Apr 3 13:29:52 2014 -0400

    ensure properly formatted json responses

commit 9846395
Author: ian <ian@addthis.com>
Date:   Thu Apr 3 09:54:49 2014 -0400

    quick fix for legacy source type inflating

commit bfb0111
Author: al <al@addthis.com>
Date:   Thu Apr 3 08:56:08 2014 -0400

    Tweak to minion/spawn minionType logic to better support minions with multiple types

commit c354ffd
Merge: 761720a 9406db1
Author: mspiegel <michael.m.spiegel@gmail.com>
Date:   Thu Apr 3 09:16:35 2014 -0400

    Merge pull request #61 from stewartoallen/at-pull-fix-replicate-script

    fix missing space in conditional in generated replication script

commit 9406db1
Author: Stewart Allen <stewart@neuron.com>
Date:   Wed Apr 2 15:17:19 2014 -0400

    fix missing space in conditional in generated replication script

commit 761720a
Author: al <al@addthis.com>
Date:   Wed Apr 2 13:37:04 2014 -0400

    Minor -- add license info to new test.

commit fe9b556
Merge: c1b87ea 9f4a806
Author: alstaplesmoore <alstaplesmoore@gmail.com>
Date:   Wed Apr 2 13:35:31 2014 -0400

    Merge pull request #60 from addthis/spawn_queue

    Spawn queue

commit 9f4a806
Author: al <al@addthis.com>
Date:   Wed Apr 2 13:28:05 2014 -0400

    Minor NPE fix

commit 44018e0
Author: al <al@addthis.com>
Date:   Tue Apr 1 15:43:05 2014 -0400

    Additional sanity check to ensure task moves obey minion types

commit 8d05bfb
Author: al <al@addthis.com>
Date:   Tue Apr 1 10:45:13 2014 -0400

    Attempt to simplify spawn queue slot tracking.

commit 27f23aa
Author: al <al@addthis.com>
Date:   Tue Apr 1 10:04:12 2014 -0400

    Disable last-host-slot feature on local stack, where it will be mostly a hindrance

commit 1ba8085
Author: al <al@addthis.com>
Date:   Tue Apr 1 09:34:15 2014 -0400

    Minor changes to signatures/naming

commit 7b0801f
Author: al <al@addthis.com>
Date:   Tue Apr 1 08:53:15 2014 -0400

    Rebalance operations attempt to use the lightest valid host.

commit ffdf246
Author: al <al@addthis.com>
Date:   Mon Mar 31 15:52:46 2014 -0400

    New jobs won't use up the last slot on a minion until after a configurable delay period

commit 1de70b5
Author: al <al@addthis.com>
Date:   Mon Mar 31 12:24:25 2014 -0400

    Minions report meanActiveTasks as a percentage of their respective maxima

commit 073658a
Author: al <al@addthis.com>
Date:   Mon Mar 31 12:01:16 2014 -0400

    Revise method signatures.

commit e542323
Author: al <al@addthis.com>
Date:   Mon Mar 31 11:12:49 2014 -0400

    Use meanActiveTasks as a tiebreak when availSlots are equal. Add tests for this behavior.

commit 2d9d8dc
Author: al <al@addthis.com>
Date:   Fri Mar 28 11:06:55 2014 -0400

    Initial work at better task allocation

commit c1b87ea
Author: ian <ian@addthis.com>
Date:   Wed Apr 2 11:00:40 2014 -0400

    correctly handle ends of dates in SSMeshy

commit 699b4e7
Merge: 4a9f8ef b73362b
Author: Ian Barfield <ian.barfield@gmail.com>
Date:   Tue Apr 1 17:37:52 2014 -0400

    Merge pull request #50 from addthis/prefetch-meshy2

    Prefetch meshy2

commit 4a9f8ef
Merge: b1e32cc d02070d
Author: Ian Barfield <ian.barfield@gmail.com>
Date:   Tue Apr 1 13:20:37 2014 -0400

    Merge pull request #58 from stewartoallen/at-pull-mesh-mq-v2

    add mesh queueing option

commit d02070d
Merge: 8f194af d9a7081
Author: Stewart Allen <stewart@neuron.com>
Date:   Tue Apr 1 12:49:00 2014 -0400

    Merge branch 'at-pull-mesh-mq-v2' of github.com:stewartoallen/hydra into at-pull-mesh-mq-v2

commit 8f194af
Author: Stewart Allen <stewart@neuron.com>
Date:   Tue Apr 1 12:48:36 2014 -0400

    patch to support hydra tests

commit d9a7081
Author: ian <ian@addthis.com>
Date:   Tue Apr 1 11:54:16 2014 -0400

    use stable meshy version

commit 0145bb7
Author: Stewart Allen <stewart@neuron.com>
Date:   Mon Mar 31 17:23:55 2014 -0400

    fix zero queue length polling lockup

commit ecacbf1
Author: Stewart Allen <stewart@neuron.com>
Date:   Mon Mar 31 16:34:56 2014 -0400

    add more extensive state debugging

commit 88edd09
Author: Stewart Allen <stewart@neuron.com>
Date:   Wed Mar 26 12:49:05 2014 -0400

    fix user-friendly output to send just a string, not a length-prefixed string

commit f187b8f
Author: Stewart Allen <stewart@neuron.com>
Date:   Wed Mar 26 09:47:26 2014 -0400

    replace stack traces with log.warn() calls

commit 3b9973a
Author: Stewart Allen <stewart@neuron.com>
Date:   Tue Mar 25 15:50:39 2014 -0400

    on-demand creation of producer queues based on routing keys
    fix first-time creation bug for queues

commit 5de3f3a
Author: Stewart Allen <stewart@neuron.com>
Date:   Tue Mar 25 01:15:12 2014 -0400

    optional mesh queueing. a replacement for rabbit
    minion/spawn comms need significant cleanup, doc and externalization
    the abstraction should be completed in subsequent patches

commit b1e32cc
Merge: fd555e6 503dd6a
Author: mspiegel <michael.m.spiegel@gmail.com>
Date:   Fri Mar 28 17:15:41 2014 -0400

    Merge pull request #56 from erichees/master

    update spawn2 templates to use auto-escaping syntax

commit 503dd6a
Author: hees <hees@addthis.com>
Date:   Fri Mar 28 16:24:07 2014 -0400

    update spawn2 templates to use auto-escaping syntax

commit b73362b
Author: ian <ian@addthis.com>
Date:   Fri Mar 21 14:41:39 2014 -0400

    clean up for mesh2 source improvements et al

    - cacheMap is accessed within the sync lock. It looks like that
    would only ever manifest a problem in a NPE. That didn't occur
    in testing, but better safe etc

    - firstData / processing range re-implemented. It had been commented
    out for convenience (it is pretty much unused). There is some more
    explicit logic that makes it clearer what and when it is used for. I
    kept it outside of the sync block, but changed the moreData variable
    to volatile. This is kind of a hedge - it may not need to be volatile
    because after all, setting firstDate to be not null isn't sync'd there
    to begin with - I don't feel great about it being actually safe but that
    is a problem for another time.

    - some optimizations related to object creation. Fewer collections are
    made, and more use initial capacity settings

    - inverse lottery selection now takes a varargs param of primitive ints.
    this helps a lot with the previous goal (collection creation), but also
    makes it a bit simpler

commit 8b290d4
Author: ian <ian@addthis.com>
Date:   Wed Mar 19 19:37:52 2014 -0400

    fix type typo

commit b6d6dcd
Author: ian <ian@addthis.com>
Date:   Wed Mar 19 19:23:11 2014 -0400

    different stealing method and linked queues

    linked queues can get size() without locking. the stealing
    variant is a little faster and adjustable

commit a5292f5
Author: ian <ian@addthis.com>
Date:   Wed Mar 19 18:55:50 2014 -0400

    removing cross-buffer max from task feeder

    much less concerned about a couple thousand bundles on heap than
    source feeder shutting down for 1000ms

commit 80fd7e3
Author: ian <ian@addthis.com>
Date:   Wed Mar 19 18:23:23 2014 -0400

    just choose the meshy host outside of the lock

commit 2fc6d23
Author: ian <ian@addthis.com>
Date:   Wed Mar 19 18:13:27 2014 -0400

    use linked queue instead of array backed

    producers were hoarding the global lock the array version uses in
    some cases

commit 3a4df93
Author: ian <ian@addthis.com>
Date:   Wed Mar 19 16:57:31 2014 -0400

    more logging for score cache

commit 2d14b5c
Author: ian <ian@addthis.com>
Date:   Wed Mar 19 16:55:16 2014 -0400

    poll time cutoff and metric for the score cache

commit 9ee9d04
Author: ian <ian@addthis.com>
Date:   Wed Mar 19 16:26:06 2014 -0400

    delay bundle skipping and compression handling

    currently we usually block waiting for a remote response as soon
    as we try to wrap the input stream in a decompression wrapper. this
    is because the constructor sometimes tries to immediately read bytes
    (like for a header or something). Bundle skipping is similar in that
    it _would_ block given the chance. This change tries to move any
    blocking network wait until after the source is pulled in turn from
    the preOpen queue.

    in order to take advantage of this change, jobs will probably need
    to make sure meshy.stream.prefetch is set to true, preOpen is large,
    and multiBundleReads is set relatively high (to try to pull as much
    available data from wraps that have already paid the initial wait -
    which tends to be the longest - before hitting the new wrap)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stewartoallen @mspiegel