fix(cleanup): delete old files when template is deleted or changed #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winged
requested changes
Nov 4, 2021
document_merge_service/api/models.py
Outdated
| try: | ||
| old_file = Template.objects.get(pk=instance.pk).template | ||
| except Template.DoesNotExist: | ||
| return False |
There was a problem hiding this comment.
Just return here, this isn't interpreted anywhere
document_merge_service/api/models.py
Outdated
| except Template.DoesNotExist: | ||
| return False | ||
|
|
||
| if bool(old_file): |
anehx
force-pushed
the
delete-file
branch
2 times, most recently
from
28f9794
to
6fa9a85
Compare
winged
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #437