Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in get depth of Problem 9.4 for python #110 #112

Merged
merged 1 commit into from
Nov 11, 2019
Merged

Fixed bug in get depth of Problem 9.4 for python #110 #112

merged 1 commit into from
Nov 11, 2019

Conversation

deveshks
Copy link
Contributor

@deveshks deveshks commented Nov 10, 2019

Fixes and closes #110

Fix for bug in get_depth for Problem 9.4 for python #110 where node.parent should be used in the while loop condition

$ python3.7 epi_judge_python_solutions/lowest_common_ancestor_with_parent.py 
Test PASSED (948/948) [   3 us]
Time complexity: O(log(size(tree))+height(tree)+log(node1))
Average running time:    4 us
Median running time:     3 us
*** You've passed ALL tests. Congratulations! ***

@tsunghsienlee
Copy link
Collaborator

Hi @deveshks ,

Thanks for this. As I mentioned in other thread, this is fixed and will be released in the next version.

@deveshks
Copy link
Contributor Author

deveshks commented Nov 11, 2019

Hi @metopa
This is the PR corresponding to issue #110 as you suggested me to create

@metopa metopa reopened this Nov 11, 2019
@metopa metopa merged commit e506638 into adnanaziz:dev Nov 11, 2019
@deveshks deveshks deleted the patch-issue-110-problem-9.4 branch November 12, 2019 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants