Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix semantic-release config to allow slashes / in commit messages #41

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

alexkli
Copy link
Contributor

@alexkli alexkli commented Oct 1, 2020

Update: did not work, no release happened.


Test to see if ** instead of * solves this issue: semantic-release/commit-analyzer#175

semantic-release/commit-analyzer uses the micromatch which is indeed a file globbing library and would then not include / in * wildcards.

Also changed the order in the config to major > minor > patch.

@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #41 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #41   +/-   ##
=======================================
  Coverage   90.62%   90.62%           
=======================================
  Files          13       13           
  Lines         821      821           
=======================================
  Hits          744      744           
  Misses         77       77           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 337116d...a4c610b. Read the comment docs.

@alexkli alexkli merged commit 8163b4f into master Oct 1, 2020
@alexkli alexkli deleted the fix-release branch October 1, 2020 22:31
@alexkli
Copy link
Contributor Author

alexkli commented Oct 1, 2020

@adobe-bot
Copy link

🎉 This PR is included in version 1.4.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants