Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mavenArgs are unused #28

Merged
merged 1 commit into from Apr 19, 2023
Merged

fix: mavenArgs are unused #28

merged 1 commit into from Apr 19, 2023

Conversation

ghost
Copy link

@ghost ghost commented Mar 8, 2023

Use mavenArgs from inputs when constructing MavenRunner so that specifying maven-args in a workflow YAML actually works.

For example

      - name: Submit Dependency Snapshot
        uses: advanced-security/maven-dependency-submission-action@v3
        with:
          maven-args: -Dmaven.repo.local=/tmp/.m2/repository

@ghost
Copy link
Author

ghost commented Mar 22, 2023

@peter-murray Am I missing anything in this PR?

@ghost ghost changed the title fix: use mavenArgs from inputs when constructing MavenRunner fix: mavenArgs are unused Mar 29, 2023
@peter-murray peter-murray merged commit 53c0ba3 into advanced-security:main Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant