Skip to content

Commit

Permalink
manager: implemented on
Browse files Browse the repository at this point in the history
  • Loading branch information
rauchg committed Dec 16, 2012
1 parent 137d87b commit 07afc2e
Showing 1 changed file with 10 additions and 4 deletions.
14 changes: 10 additions & 4 deletions lib/manager.js
Original file line number Diff line number Diff line change
Expand Up @@ -121,22 +121,26 @@ Manager.prototype.timeout = function(v){
/**
* Sets the current transport `socket`.
*
* @param {Socket} socket
* @param {Function} optional, callback
* @return {Manager} self
* @api public
*/

Manager.prototype.open =
Manager.prototype.connect = function(socket, fn){
Manager.prototype.connect = function(fn){
if (~this.readyState.indexOf('open')) return this;

var socket = this.engine;
var self = this;
var timerSub;

this.readyState = 'opening';

// emit `open`
var openSub = socket.on('open', bind(this, 'onopen'));
var openSub = on(socket, 'open', bind(this, 'onopen'));

// emit `connect_error`
var errorSub = socket.on('error', function(data){
var errorSub = on(socket, 'error', function(data){
self.cleanup();
self.emit('connect_error', data);
if (fn) {
Expand Down Expand Up @@ -173,6 +177,8 @@ Manager.prototype.connect = function(socket, fn){

this.subs.push(openSub);
this.subs.push(errorSub);

return this;
};

/**
Expand Down

0 comments on commit 07afc2e

Please sign in to comment.