Skip to content

Commit

Permalink
Fix review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
sergeyshevch committed Apr 20, 2024
1 parent 0140b71 commit 61d57de
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions api/v1alpha1/etcdcluster_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ type EtcdClusterSpec struct {
ServiceTemplate *ServiceSpec `json:"serviceTemplate,omitempty"`
// HeadlessService defines the desired state of HeadlessService for etcd members. If not specified, default values will be used.
// +optional
HeadlessServiceTemplate *EmbeddedeMetadataResourse `json:"headlessServiceTemplate,omitempty"`
HeadlessServiceTemplate *EmbeddedMetadataResource `json:"headlessServiceTemplate,omitempty"`
// PodDisruptionBudgetTemplate describes PDB resource to create for etcd cluster members. Nil to disable.
// +optional
PodDisruptionBudgetTemplate *EmbeddedPodDisruptionBudget `json:"podDisruptionBudgetTemplate,omitempty"`
Expand Down Expand Up @@ -241,7 +241,7 @@ type ServiceSpec struct {
Spec corev1.ServiceSpec `json:"spec,omitempty" protobuf:"bytes,2,opt,name=spec"`
}

type EmbeddedeMetadataResourse struct {
type EmbeddedMetadataResource struct {
// EmbeddedMetadata contains metadata relevant to an EmbeddedResource.
// +optional
EmbeddedObjectMetadata `json:"metadata,omitempty" protobuf:"bytes,1,opt,name=metadata"`
Expand Down
10 changes: 5 additions & 5 deletions api/v1alpha1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion internal/controller/factory/svc_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ var _ = Describe("CreateOrUpdateService handlers", func() {
It("should successfully create the cluster service with custom metadata", func() {
svc := &corev1.Service{}
cluster := etcdcluster.DeepCopy()
cluster.Spec.HeadlessServiceTemplate = &etcdaenixiov1alpha1.EmbeddedeMetadataResourse{
cluster.Spec.HeadlessServiceTemplate = &etcdaenixiov1alpha1.EmbeddedMetadataResource{
EmbeddedObjectMetadata: etcdaenixiov1alpha1.EmbeddedObjectMetadata{
Name: "headless-name",
Labels: map[string]string{"label": "value"},
Expand Down

0 comments on commit 61d57de

Please sign in to comment.