Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNT] Replace Intel macOS runners with m1 macOS runners in CI #1585

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

[MNT] Replace Intel macOS runners with m1 macOS runners in CI #1585

wants to merge 13 commits into from

Conversation

chrisholder
Copy link
Contributor

@chrisholder chrisholder commented May 31, 2024 •
edited by MatthewMiddlehurst
Loading

Reference Issues/PRs

Fixes #1628

What does this implement/fix? Explain your changes.

Updates the macOS runners, which uses the "new" ARM processors. This does not play well with results checking, so these are skipped for a few tests and general tests.

Updates installation docs to reflect this.

@aeon-actions-bot aeon-actions-bot bot added the maintenance Continuous integration, unit testing & package distribution label May 31, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#EC843A}{\textsf{maintenance}}$ ].

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

@chrisholder
Copy link
Contributor Author

This is going to be a long and painful swap so this PR maybe open for a while...

@MatthewMiddlehurst MatthewMiddlehurst added the full pytest actions Run the full pytest suite on a PR label Jun 4, 2024
@MatthewMiddlehurst MatthewMiddlehurst mentioned this pull request Jun 4, 2024
Open
@TonyBagnall TonyBagnall mentioned this pull request Jun 7, 2024
Open
@MatthewMiddlehurst MatthewMiddlehurst changed the title [MNT] CI use m1 macos runner [MNT] Replace Intel macOS runners with m1 macOS runners in CI Jun 23, 2024
@MatthewMiddlehurst MatthewMiddlehurst added the testing Testing related issue or pull request label Jun 23, 2024
@MatthewMiddlehurst MatthewMiddlehurst marked this pull request as ready for review June 23, 2024 22:37
@MatthewMiddlehurst
Copy link
Member

I have updated this PR

@patrickzib
Copy link
Contributor

patrickzib commented Jun 24, 2024 •
edited
Loading

Hi @MatthewMiddlehurst, why are there problems with ARM for TEASER and test_all_classifiers? I am on an ARM M1. Can have a look later on today.

@MatthewMiddlehurst
Copy link
Member

It produces different outputs compared to our Unix and Windows runners @patrickzib. No idea if the difference is significant (probably not, it's the same algorithm), but it's enough to fail the test.

There are enough of these failures that I'm honestly not that bothered about making sure it produces the same output as windows/linux.

@MatthewMiddlehurst
Merge branch 'main' of https://github.com/aeon-toolkit/aeon into use-…
885c9de 
…m1-test

# Conflicts:
#	.github/workflows/periodic_tests.yml
#	.github/workflows/pr_pytest.yml
#	.github/workflows/release.yml
@MatthewMiddlehurst
docs
64a2984
@MatthewMiddlehurst
Merge branch 'main' of https://github.com/aeon-toolkit/aeon into use-…
382102f 
…m1-test
chrisholder
chrisholder commented Jun 27, 2024
View reviewed changes
Copy link
Contributor Author

@chrisholder chrisholder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me don't know if you plan to do anything more but just like this seems like a great start! (I would approve but cant approve my own pr lol)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthewMiddlehurst MatthewMiddlehurst Awaiting requested review from MatthewMiddlehurst MatthewMiddlehurst is a code owner

@TonyBagnall TonyBagnall Awaiting requested review from TonyBagnall TonyBagnall is a code owner

@dguijo dguijo Awaiting requested review from dguijo dguijo is a code owner

@aiwalter aiwalter Awaiting requested review from aiwalter aiwalter is a code owner

@GuzalBulatova GuzalBulatova Awaiting requested review from GuzalBulatova GuzalBulatova is a code owner

@ltsaprounis ltsaprounis Awaiting requested review from ltsaprounis ltsaprounis is a code owner

@patrickzib patrickzib Awaiting requested review from patrickzib patrickzib is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
full pytest actions Run the full pytest suite on a PR maintenance Continuous integration, unit testing & package distribution testing Testing related issue or pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MNT] Abandon intel MacOS CI test runs
3 participants
@chrisholder @MatthewMiddlehurst @patrickzib