Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Diagnostics for BasicMotions with HC2, numba stripped out #1650

Closed
wants to merge 12 commits into from

Conversation

TonyBagnall
Copy link
Contributor

stripped out njit to the point where it still passes locally, seems to have narrowed it down to shaplet transform

@aeon-actions-bot aeon-actions-bot bot added bug Something isn't working classification Classification package testing Testing related issue or pull request transformations Transformations package labels Jun 11, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#d73a4a}{\textsf{bug}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#BCAE15}{\textsf{classification}}$, $\color{#2C2F20}{\textsf{testing}}$, $\color{#41A8F6}{\textsf{transformations}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

@TonyBagnall TonyBagnall changed the title [BUG] Diagnostics for BasicMotions witt HC2, numba stripped out [BUG] Diagnostics for BasicMotions with HC2, numba stripped out Jun 11, 2024
@TonyBagnall
Copy link
Contributor Author

after this the next stage is ShapeletTransform

_extract_random_shapelet (not njit)
@njit methods
z_normalise_series
_find_shapelet_quality
_online_shapelet_distance (this has a bespoke std calculation that calls math.sqrt. It also calls zip)
_calc_early_binary_ig
_binary_entropy
_calc_binary_ig
_binary_entropy

whats weird to me is if I turn numba off on the outermost method, _find_shapelet_quality, it crashes,

 File "C:\Code\aeon\aeon\transformations\collection\base.py", line 327, in _fit_transform
    self._fit(X, y)
  File "C:\Code\aeon\aeon\transformations\collection\shapelet_based\_shapelet_transform.py", line 297, in _fit
    candidate_shapelets = Parallel(
  File "C:\Code\aeon\venv\lib\site-packages\joblib\parallel.py", line 1918, in __call__
    return output if self.return_generator else list(output)
  File "C:\Code\aeon\venv\lib\site-packages\joblib\parallel.py", line 1847, in _get_sequential_output
    res = func(*args, **kwargs)
  File "C:\Code\aeon\aeon\transformations\collection\shapelet_based\_shapelet_transform.py", line 446, in _extract_random_shapelet
    quality = self._find_shapelet_quality(
  File "C:\Code\aeon\aeon\transformations\collection\shapelet_based\_shapelet_transform.py", line 513, in _find_shapelet_quality
    quality = _calc_binary_ig(orderline, this_cls_count, other_cls_count)
TypeError: can't unbox heterogeneous list: UniTuple(int64 x 2) != Tuple(float64, int64)

logically, I thought you should be able to turn off the outer methods

@TonyBagnall
Copy link
Contributor Author

so seems ST is the culprit.

@TonyBagnall TonyBagnall closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working classification Classification package testing Testing related issue or pull request transformations Transformations package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant