Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEP] Deprecate BaseTransformer #1683

Closed
wants to merge 25 commits into from
Closed

[DEP] Deprecate BaseTransformer #1683

wants to merge 25 commits into from

Conversation

TonyBagnall
Copy link
Contributor

last one out, turn off the lights, The whole lot will be removed, refactored or brushed under the carpet by release 0.11

@TonyBagnall TonyBagnall added transformations Transformations package deprecation This issue is related to deprecation or removal of code labels Jun 14, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I would have added the following labels to this PR based on the changes made: [ $\color{#41A8F6}{\textsf{transformations}}$ ], however some package labels are already present.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)

@MatthewMiddlehurst
Copy link
Member

Could you run one of the currently deprecated estimators and make sure there are not 2 warning printed because of this?

@MatthewMiddlehurst
Copy link
Member

MatthewMiddlehurst commented Jul 2, 2024

I'm going to propose we just roll this into v1.0.0 with one single package-wide deprecation message. Helps us avoid the above issue, and by that point hopefully it's just on its own with nothing using it.

@TonyBagnall TonyBagnall closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation This issue is related to deprecation or removal of code transformations Transformations package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants