refactor(contract)!: remove contractGetACI

use sdk.compilerApi.generateACI instead

src/contract/aci/index.js

@@ -91,7 +91,9 @@ export default async function getContractInstance ({
   validateBytecode,
   ...otherOptions
 } = {}) {
-  aci = aci || (source && await this.contractGetACI(source, { filesystem }))
+  if (!aci && source) {
+    aci = await this.compilerApi.generateACI({ code: source, options: { filesystem } })
+  }
   if (!aci) throw new MissingContractDefError()
   contractAddress = contractAddress && await this.resolveName(
     contractAddress, 'contract_pubkey', { resolveByNode: true }

src/contract/compiler.js

@@ -128,10 +128,6 @@ export default AsyncInit.compose(ContractBase, {
       this._ensureCompilerReady()
       const { bytecode } = await this.compilerApi.compileContract({ code, options })
       return bytecode
-    },
-    contractGetACI (code, options) {
-      this._ensureCompilerReady()
-      return this.compilerApi.generateACI({ code, options })
     }
   },
   props: {

src/contract/index.js

@@ -41,25 +41,11 @@ const ContractBase = stampit(required({
   methods: {
     contractEncodeCallDataAPI: required,
     compileContractAPI: required,
-    contractGetACI: required,
     setCompilerUrl: required,
     getCompilerVersion: required
   }
 }))
 
-/**
- * Get contract ACI
- * @function contractGetACI
- * @instance
- * @abstract
- * @category async
- * @rtype (source: String, options: Array) => aciObject: Promise[Object]
- * @param {String} source - Contract source code
- * @param {Object} [options={}]  Options
- * @param {Object} [options.filesystem]  Contract external namespaces map
- * @return {Object} - Contract aci object
- */
-
 /**
  * Encode contract data
  * @function contractEncodeCallDataAPI

test/integration/contract-aci.js

@@ -126,7 +126,8 @@ describe('Contract instance', function () {
 
   before(async function () {
     sdk = await getSdk()
-    testContractAci = await sdk.contractGetACI(testContractSource, { filesystem })
+    testContractAci = await sdk.compilerApi
+      .generateACI({ code: testContractSource, options: { filesystem } })
     testContractBytecode = (await sdk.contractCompile(testContractSource, { filesystem })).bytecode
   })
 
@@ -230,7 +231,8 @@ describe('Contract instance', function () {
 
   it('rejects not matching bytecode with enabled validation', async () => expect(sdk.getContractInstance({
     bytecode: (await sdk.contractCompile(identityContractSource)).bytecode,
-    aci: await sdk.contractGetACI(identityContractSource, { filesystem }),
+    aci: await sdk.compilerApi
+      .generateACI({ code: identityContractSource, options: { filesystem } }),
     contractAddress: testContractAddress,
     validateBytecode: true
   })).to.be.rejectedWith(BytecodeMismatchError, 'Contract bytecode do not correspond to the bytecode deployed on the chain'))

test/integration/contract.js

@@ -309,13 +309,15 @@ describe('Contract', function () {
       )
     })
 
-    it('get contract ACI', async () => {
-      const aci = await sdk.contractGetACI(identityContract)
-      aci.should.have.property('interface')
+    it('generate contract ACI', async () => {
+      const aci = await sdk.compilerApi.generateACI({ code: identityContract })
+      expect(aci).to.have.property('encoded_aci')
+      expect(aci).to.have.property('external_encoded_aci')
+      expect(aci).to.have.property('interface')
     })
 
     it('throws clear exception if generating ACI with no arguments', async () => {
-      await expect(sdk.contractGetACI())
+      await expect(sdk.compilerApi.generateACI())
         .to.be.rejectedWith('validation_error in body ({"error":"missing_required_property","data":"code","path":[]})')
     })