fix(Crypto): Fix keypair verification (#605)

* convert test message to buffer in isValidKeypair fixes aeternity/aepp-base#1090 * add test for keypair validity verification
aeternity · Aug 14, 2019 · 83a52fb · 83a52fb
1 parent 14eaa3d
commit 83a52fb
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/es/utils/crypto.js b/es/utils/crypto.js
@@ -498,7 +498,7 @@ export function encodeTx (txData) {
  * @return {Boolean} Valid?
  */
 export function isValidKeypair (privateKey, publicKey) {
-  const message = 'TheMessage'
+  const message = Buffer.from('TheMessage')
   const signature = sign(message, privateKey)
   return verify(message, signature, publicKey)
 }

diff --git a/test/unit/crypto.js b/test/unit/crypto.js
@@ -48,7 +48,16 @@ describe('crypto', () => {
       assert.isAtMost(keyPair.publicKey.length, 53)
     })
   })
-
+
+  describe('isValidKeypair', () => {
+    it('verify the generated key pair', () => {
+      const keyPair = Crypto.generateKeyPair(true)
+      assert.ok(keyPair)
+      const verifyResult = Crypto.isValidKeypair(keyPair.secretKey, keyPair.publicKey)
+      assert.isTrue(verifyResult)
+    })
+  })
+
   describe('encryptPassword', () => {
     describe('generate a password encrypted key pair', () => {
       const keyPair = Crypto.generateKeyPair(true)