fix: reject prefixes other then provided in isAddressValid

aeternity · May 5, 2023 · 9462add · 9462add
1 parent 1f8c70a
commit 9462add
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/src/utils/crypto.ts b/src/utils/crypto.ts
@@ -8,6 +8,7 @@ import { concatBuffers } from './other';
 import {
   decode, encode, Encoded, Encoding,
 } from './encoder';
+import { ArgumentError } from './errors';
 
 /**
  * Generate address from secret key
@@ -32,6 +33,10 @@ export function isAddressValid(
 ): boolean {
   try {
     decode(address as Encoded.Generic<typeof prefix>);
+    const actualPrefix = address.split('_')[0];
+    if (actualPrefix !== prefix) {
+      throw new ArgumentError('Encoded string type', prefix, actualPrefix);
+    }
     return true;
   } catch (e) {
     return false;

diff --git a/test/unit/crypto.ts b/test/unit/crypto.ts
@@ -56,6 +56,7 @@ describe('crypto', () => {
 
   it('isAddressValid', () => {
     expect(isAddressValid('test')).to.be.equal(false);
+    expect(isAddressValid('th_11111111111111111111111111111111273Yts')).to.be.equal(false);
     expect(isAddressValid('ak_11111111111111111111111111111111273Yts')).to.be.equal(true);
   });