Merge pull request #1565 from aeternity/fix/cross-aepp-wallet-comp

fix(aepp): use networkId in rpc tx signing
aeternity · Jun 17, 2022 · a7ef9f1 · a7ef9f1
2 parents 967de89 + 916dba0
commit a7ef9f1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/account/rpc.ts b/src/account/rpc.ts
@@ -42,7 +42,13 @@ export default class AccountRpc extends AccountBase {
     const res = await this._rpcClient.request(METHODS.sign, {
       onAccount: this._address,
       tx,
-      returnSigned: true
+      returnSigned: true,
+      /**
+       * @deprecated Wallet provided networkId will be used (current network)
+       * required to maintain backward compatibility with wallets using SDK v11.0.1 and below
+       * @see {@link https://github.com/aeternity/aepp-sdk-js/commit/153fd89a52c4eab39fcd659b356b36d32129c1ba}
+       */
+      networkId
     })
     return res.signedTransaction
   }

diff --git a/tsdoc.json b/tsdoc.json
@@ -11,6 +11,7 @@
     "@link": true,
     "@see": true,
     "@example": true,
-    "@category": true
+    "@category": true,
+    "@deprecated": true
   }
 }