fix(aepp): don't require connection to wallet to make a static call

src/contract/Contract.ts

@@ -46,6 +46,7 @@ import {
   AmbiguousEventDefinitionError,
   UnexpectedTsError,
   InternalError,
+  NoWalletConnectedError,
 } from '../utils/errors';
 import { hash as calcHash } from '../utils/crypto';
 import { Aci as BaseAci } from '../apis/compiler';
@@ -357,11 +358,11 @@ class Contract<M extends ContractMethodsBase> {
     try {
       callerId = opt.onAccount.address;
     } catch (error) {
-      const messageToSwallow = 'Account should be an address (ak-prefixed string), or instance of AccountBase, got undefined instead';
-      if (
-        opt.callStatic !== true || !(error instanceof TypeError)
-        || error.message !== messageToSwallow
-      ) throw error;
+      const useFallbackAccount = opt.callStatic === true && (
+        (error instanceof TypeError && error.message === 'Account should be an address (ak-prefixed string), or instance of AccountBase, got undefined instead')
+        || (error instanceof NoWalletConnectedError)
+      );
+      if (!useFallbackAccount) throw error;
       callerId = DRY_RUN_ACCOUNT.pub;
     }
     const callData = this._calldata.encode(this._name, fn, params);

test/integration/rpc.ts

@@ -20,6 +20,7 @@ import {
 } from 'mocha';
 import { expect } from 'chai';
 import {
+  AeSdk,
   AeSdkAepp,
   AeSdkWallet,
   BrowserWindowMessageConnection,
@@ -102,11 +103,13 @@ describe('Aepp<->Wallet', function aeppWallet() {
 
   describe('New RPC Wallet-AEPP: AEPP node', () => {
     const keypair = generateKeyPair();
+    let aeSdk: AeSdk;
     let aepp: AeSdkAepp;
     let wallet: AeSdkWallet;
 
     before(async () => {
-      [account] = Object.values((await getSdk()).accounts);
+      aeSdk = await getSdk();
+      [account] = Object.values(aeSdk.accounts);
       wallet = new AeSdkWallet({
         nodes: [{ name: 'local', instance: node }],
         accounts: [account, MemoryAccount.generate()],
@@ -127,6 +130,24 @@ describe('Aepp<->Wallet', function aeppWallet() {
       });
     });
 
+    it('aepp can do static calls without connection to wallet', async () => {
+      const contract = await aeSdk.initializeContract({
+        sourceCode: 'contract Test =\n'
+          + '  entrypoint getArg(x : int) = x',
+      });
+      await contract.$deploy([]);
+      const aeppSdk = new AeSdkAepp({
+        name: 'AEPP',
+        nodes: [{ name: 'test', instance: node }],
+        compilerUrl: aeSdk._options.compilerUrl,
+      });
+      const contractAepp = await aeppSdk.initializeContract<{ getArg: (a: number) => number }>({
+        aci: contract._aci,
+        address: contract.$options.address,
+      });
+      expect((await contractAepp.getArg(42)).decodedResult).to.be.equal(42n);
+    });
+
     it('Fail on not connected', async () => {
       await Promise.all([
         aepp.subscribeAddress(SUBSCRIPTION_TYPES.subscribe, 'current'),