refactor(compiler)!: remove getCompilerVersion

use sdk.compilerVersion instead
aeternity · Jan 24, 2022 · fb929f8 · fb929f8
1 parent 5ae9c62
commit fb929f8
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 25 deletions.
diff --git a/docs/guides/connect-aepp-to-wallet.md b/docs/guides/connect-aepp-to-wallet.md
@@ -23,12 +23,12 @@ async created () {
     compilerUrl: COMPILER_URL,
     onNetworkChange: async (params) => {
       this.client.selectNode(params.networkId)
-      this.nodeInfoResponse = await errorAsField(this.client.getNodeInfo())
+      this.nodeInfoResponse = await this.client.getNodeInfo()
     },
     onAddressChange:  async (addresses) => {
       this.pub = await this.client.address()
       this.balance = await this.client.balance(this.pub).catch(e => '0')
-      this.addressResponse = await errorAsField(this.client.address())
+      this.addressResponse = await this.client.address()
     },
     onDisconnect: () => {
       this.resetState()
@@ -73,9 +73,8 @@ async connectToWallet (wallet) {
   this.onAccount = this.pub
   this.balance = await this.client.getBalance(this.pub)
   this.walletName = this.client.rpcClient.info.name
-  this.addressResponse = await errorAsField(this.client.address())
-  this.heightResponse = await errorAsField(this.client.height())
-  this.nodeInfoResponse = await errorAsField(this.client.getNodeInfo())
-  this.compilerVersionResponse = await errorAsField(this.client.getCompilerVersion())
+  this.addressResponse = await this.client.address()
+  this.heightResponse = await this.client.height()
+  this.nodeInfoResponse = await this.client.getNodeInfo()
 }
 ```
diff --git a/examples/browser/aepp/src/Basic.vue b/examples/browser/aepp/src/Basic.vue
@@ -19,7 +19,7 @@
     </div>
     <div>
       <div>Compiler version</div>
-      <Value :value="compilerVersionPromise" />
+      <div>{{ compilerVersion }}</div>
     </div>
   </div>
 
@@ -69,7 +69,7 @@ export default {
     balancePromise: null,
     heightPromise: null,
     nodeInfoPromise: null,
-    compilerVersionPromise: null,
+    compilerVersion: '',
     spendTo: '',
     spendAmount: '',
     spendPayload: '',
@@ -80,7 +80,7 @@ export default {
       ({ sdk, address, networkId }) => [sdk, address, networkId],
       ([sdk, address]) => {
         if (!sdk) return
-        this.compilerVersionPromise = sdk.getCompilerVersion()
+        this.compilerVersion = sdk.compilerVersion
         this.balancePromise = sdk.balance(address)
         this.heightPromise = sdk.height()
         this.nodeInfoPromise = sdk.getNodeInfo()

diff --git a/src/contract/compiler.js b/src/contract/compiler.js
@@ -99,10 +99,6 @@ export default AsyncInit.compose(ContractBase, {
     _ensureCompilerReady () {
       if (!this.compilerApi) throw new UnavailableCompilerError()
     },
-    getCompilerVersion () {
-      this._ensureCompilerReady()
-      return Promise.resolve(this.compilerVersion)
-    },
     /**
      * Encode call data for contract call
      * @function

diff --git a/src/contract/index.js b/src/contract/index.js
@@ -40,8 +40,7 @@ import { required } from '@stamp/required'
 const ContractBase = stampit(required({
   methods: {
     contractEncodeCallDataAPI: required,
-    setCompilerUrl: required,
-    getCompilerVersion: required
+    setCompilerUrl: required
   }
 }))
 
@@ -71,14 +70,4 @@ const ContractBase = stampit(required({
  * @return {void}
  */
 
-/**
- * Get Compiler Version
- * @function getCompilerVersion
- * @instance
- * @abstract
- * @category async
- * @rtype () => String
- * @return {String} Compiler version
- */
-
 export default ContractBase