Wallet ID is missed in Identity example in Chrome #902
Labels
bug
Something isn't working
Comments
|
Actually it's doesn't break AEPP, because when you are using Iframe/reverse iframe you don't need this id, this is required only for extension connection |
nduchak
added a commit
that referenced
this issue
Feb 18, 2020
nduchak
added a commit
that referenced
this issue
Feb 19, 2020
* feat(Account): Add `signMessage` method to Account stamp * feat(AEX-2): Add `signMessage` method and new request to RPC * feat(AEX-2): Fix action arguments propagation * feat(AEX-2): Fix example app * feat(AEX-2): Fix broken example app. Fix default option for RpcWallet Resolve https://github.com/aeternity/tipwallet/issues/87 Resolve #902, #899 * feat(MessageSigning): Replace `æ` with `ae` in message prefix Make blake2b hash of message before signing Add `verifyMessage` method to memory account stamp Fix test's * feat(MessageSigning): Add `onMessageSign` event to WalletRpc * feat(MessageSigning): Add test for RPC signing * docs(API): Generate docs
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
aepp-sdk-js/es/utils/aepp-wallet-communication/rpc/wallet-rpc.js
Line 276 in c5fa163
chrome.runtimeis defined in Chrome's global scope of a usual tab (not an extension), so the condition above will be truly, butchrome.runtime.idis not defined, it will lead to sending the wallet info without id that breaks the aepp side.The text was updated successfully, but these errors were encountered: