Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests configuration more flexible #1037

Merged
merged 1 commit into from
Jul 3, 2020

Conversation

davidyuk
Copy link
Member

@davidyuk davidyuk commented Jun 19, 2020

  • don't require keypair defined in env variables
  • allow using a different keypair without changing tests

The original problem is that I was trying to run tests locally, but wasn't able to find the private key of ak_2a1j2Mk9YSmC1gioUq4PWRm3bsv887MbuRVwyv4KaUGoR1eiKi

@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #1037 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1037   +/-   ##
========================================
  Coverage    93.63%   93.63%           
========================================
  Files           58       58           
  Lines         2952     2952           
========================================
  Hits          2764     2764           
  Misses         188      188           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b00d781...e91f4ac. Read the comment docs.

@davidyuk davidyuk force-pushed the feature/make-tests-configs-more-flexible branch 7 times, most recently from 6744cc4 to 3b550ae Compare June 21, 2020 05:10
@davidyuk davidyuk marked this pull request as ready for review June 21, 2020 06:00
@davidyuk davidyuk requested a review from nduchak June 21, 2020 06:00
@mradkov mradkov added this to the 7.4.3 milestone Jul 1, 2020
- don't require keypair defined in env variables
- allow to use a different keypair without changing keys
@davidyuk davidyuk force-pushed the feature/make-tests-configs-more-flexible branch from 3b550ae to e91f4ac Compare July 2, 2020 08:25
@davidyuk davidyuk merged commit a10f340 into develop Jul 3, 2020
@davidyuk davidyuk deleted the feature/make-tests-configs-more-flexible branch July 3, 2020 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants