Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests #1039

Merged
merged 9 commits into from
Jul 3, 2020
Merged

Refactor tests #1039

merged 9 commits into from
Jul 3, 2020

Conversation

davidyuk
Copy link
Member

@davidyuk davidyuk commented Jun 20, 2020

@codecov
Copy link

codecov bot commented Jun 20, 2020

Codecov Report

Merging #1039 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1039   +/-   ##
========================================
  Coverage    93.63%   93.63%           
========================================
  Files           58       58           
  Lines         2953     2953           
========================================
  Hits          2765     2765           
  Misses         188      188           
Impacted Files Coverage Δ
es/ae/index.js 100.00% <100.00%> (ø)
es/contract/aci/index.js 95.34% <100.00%> (ø)
es/tx/builder/index.js 83.21% <100.00%> (ø)
es/tx/validator.js 100.00% <100.00%> (ø)
es/utils/amount-formatter.js 100.00% <100.00%> (ø)
es/utils/bignumber.js 100.00% <100.00%> (ø)
es/utils/bytes.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ded444...9494365. Read the comment docs.

@nduchak
Copy link
Contributor

nduchak commented Jun 20, 2020

account2 is used in tests, try to find “ onAccount” in test folder

@davidyuk
Copy link
Member Author

onAccount mentioned 82 times in tests folder, can you point a specific use case?
I have assumed that account2 is not used because it is not imported anywhere, also tests did not fall after removing it 🤷‍♀️
I would suggest defining account2 exactly in tests that are using it.

@davidyuk davidyuk marked this pull request as ready for review June 21, 2020 00:27
@davidyuk davidyuk marked this pull request as draft June 21, 2020 05:00
@davidyuk davidyuk force-pushed the feature/refactor-tests branch 4 times, most recently from 0c27318 to 1eb8a7b Compare June 21, 2020 09:12
@davidyuk davidyuk marked this pull request as ready for review June 21, 2020 10:10
@mradkov mradkov added this to the 7.4.3 milestone Jul 1, 2020
@davidyuk davidyuk merged commit de9f3c7 into develop Jul 3, 2020
@davidyuk davidyuk deleted the feature/refactor-tests branch July 3, 2020 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants