-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and make smaller browser script #1209
Conversation
reverts 03c2dcb node_modules/rlp/dist/index.js doesn't contain `const` anymore, but this processing was breaking import of commonjs module
Fixes error: ReferenceError: process is not defined `process` referenced in pbkdf2 package
Fixes error: ReferenceError: Buffer is not defined
Codecov Report
@@ Coverage Diff @@
## develop #1209 +/- ##
============================================
- Coverage 93.59% 70.79% -22.81%
============================================
Files 54 54
Lines 2609 2609
Branches 24 24
============================================
- Hits 2442 1847 -595
- Misses 155 759 +604
+ Partials 12 3 -9
Continue to review full report at Codecov.
|
5e01694
to
24f946f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Perhaps we can gradually refactor to drop the R
usage across the whole SDK?
before:
after this and #1208:
fixes
aepp-sdk.browser-script.js
package, discussed in https://forum.aeternity.com/t/issues-with-sdk8-0-0/9453/8also should fix this issue: browserify/pbkdf2#48 (comment) 😃