Generate compiler api in TypeScript using autorest #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidyuk
commented
Apr 1, 2022
| validateBytecode, | ||
| ...otherOptions | ||
| } = {}) { | ||
| if (!_aci && source) { | ||
| _aci = await this.compilerApi.generateACI({ code: source, options: { filesystem } }) | ||
| _aci = await this.compilerApi.generateACI({ code: source, options: { fileSystem } }) |
There was a problem hiding this comment.
for some reason sdk and aesophia_http names this option differently
davidyuk
force-pushed
the
feature/ts-compiler-api
branch
2 times, most recently
from
6504ec6
to
b824bb6
Compare
davidyuk
force-pushed
the
feature/ts-compiler-api
branch
from
b824bb6
to
7a61a2f
Compare
|
Apart from the need of rebasing, I think it looks great! I could also suggest updating the testing docs so contributors know that they need to run "test": "checkApi && nyc mocha './test/unit/' './test/integration/'", Finally, since |
davidyuk
force-pushed
the
feature/ts-compiler-api
branch
from
7a61a2f
to
a9cfb13
Compare
BREAKING CHANGE: `filesystem` option renamed to `fileSystem` BREAKING CHANGE: methods of `compilerApi` requires `options` object according to their specification BREAKING CHANGE: methods of `compilerApi` returns and accepts keys named in camelCase instead of snake_case
BREAKING CHANGE: `ContractCompilerHttp` creates and changes compiler URL in sync Don't tread `ContractCompilerHttp(...)` and `compiler.setCompilerUrl(...)` as a `Promise` anymore. BREAKING CHANGE: `ContractCompilerHttp` doesn't check version on creating and switching the url This would be checked before the first request.
davidyuk
force-pushed
the
feature/ts-compiler-api
branch
from
a9cfb13
to
b0c33b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes partially #1216
found issues: aeternity/aesophia_http#87 aeternity/aesophia_http#88 aeternity/aesophia_http#90 aeternity/aesophia_http#91