Fix build issue | refactor encoder types #1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidyuk
requested changes
May 17, 2022
|
This pull request introduces 15 alerts when merging 8598e7a into c20b373 - view on LGTM.com new alerts:
|
subhod-i
force-pushed
the
feature/account-ts
branch
from
8598e7a
to
50228ec
Compare
|
This pull request introduces 15 alerts when merging 50228ec into c20b373 - view on LGTM.com new alerts:
|
subhod-i
force-pushed
the
feature/account-ts
branch
from
50228ec
to
1f112f4
Compare
|
This pull request introduces 15 alerts when merging 1f112f4 into c20b373 - view on LGTM.com new alerts:
|
davidyuk
force-pushed
the
feature/account-ts
branch
from
1f112f4
to
016d2b8
Compare
davidyuk
approved these changes
May 17, 2022
|
This pull request introduces 15 alerts when merging 016d2b8 into 18d907b - view on LGTM.com new alerts:
|
|
👆 this is the first time lgtm find something useful, the second argument should be removed there as well, but we shouldn't forget prefixes while converting to TS |
BREAKING CHANGE: since the prefix is evaluated by the type
itself the required prefix parameter is no more required.
rewrite
```js
decode('cb_DA6sWJo=', 'cb')
```
to
```js
decode('cb_DA6sWJo=')
```
subhod-i
force-pushed
the
feature/account-ts
branch
from
016d2b8
to
dec13d7
Compare
|
This pull request introduces 13 alerts when merging dec13d7 into 307557e - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.