refactor(tests): migrate remaining tests ts #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subhod-i
reviewed
May 20, 2022
subhod-i
reviewed
May 23, 2022
subhod-i
reviewed
May 23, 2022
subhod-i
approved these changes
May 23, 2022
davidyuk
requested changes
May 25, 2022
test/unit/memory-account.ts
Outdated
| @@ -43,23 +43,23 @@ describe('MemoryAccount', function () { | |||
| }) | |||
|
|
|||
| it('Init with secretKey as hex string', async () => { | |||
| const acc = MemoryAccount({ keypair: testAcc }) | |||
| return acc.address().should.eventually.be.equal(testAcc.publicKey) | |||
| const acc: _AccountMemory = MemoryAccount({ keypair: testAcc }) | |||
There was a problem hiding this comment.
Suggested change
| const acc: _AccountMemory = MemoryAccount({ keypair: testAcc }) | |
| const acc = MemoryAccount({ keypair: testAcc }) |
didn't we already defined MemoryAccount as _AccountMemory?
There was a problem hiding this comment.
Yes, but it's a stamp, so acc gets an any type without the : _AccountMemory
davidyuk
reviewed
May 27, 2022
davidyuk
reviewed
May 27, 2022
martinkaintas
force-pushed
the
feature/ts-tests
branch
from
0711007
to
8b797f5
Compare
davidyuk
requested changes
Jun 7, 2022
src/utils/aepp-wallet-communication/connection/BrowserWindowMessage.ts
Outdated
Show resolved
Hide resolved
src/utils/aepp-wallet-communication/connection/BrowserWindowMessage.ts
Outdated
Show resolved
Hide resolved
test/integration/contract.ts
Outdated
| const queryFee = 500000 | ||
| const ttl = { RelativeTTL: [50] } | ||
|
|
||
| before(async () => { | ||
| contract = await aeSdk.getContractInstance({ source: oracleContract }) | ||
| await contract.deploy() | ||
| await contract.deploy([], {}) | ||
| if (contract.deployInfo.address == null) throw new InternalError('Expected to not happen, required for TS') |
There was a problem hiding this comment.
can deploy function assert that deployInfo.address would be present?
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-7.html#assertion-functions
There was a problem hiding this comment.
We can add a function like this one, and use it to assert that deployInfo.address will be present at a certain scope. But I don't think we can make deploy itself do both.
export function assertAddress (address: any): asserts address is EncodedData<'ct'> {
if (address == null) throw new IllegalArgumentError('Address is required')
}
martinkaintas
force-pushed
the
feature/ts-tests
branch
from
8b797f5
to
739656c
Compare
martinkaintas
force-pushed
the
feature/ts-tests
branch
from
739656c
to
c5ec62b
Compare
davidyuk
force-pushed
the
develop
branch
3 times, most recently
from
7db7a95
to
d3f7904
Compare
martinkaintas
force-pushed
the
feature/ts-tests
branch
2 times, most recently
from
ff9a8a1
to
6b19bd8
Compare
martinkaintas
force-pushed
the
feature/ts-tests
branch
2 times, most recently
from
1ac7bf7
to
57fd1ee
Compare
davidyuk
force-pushed
the
feature/ts-tests
branch
from
57fd1ee
to
71d3592
Compare
|
This pull request introduces 5 alerts when merging 71d3592 into 88d25af - view on LGTM.com new alerts:
|
davidyuk
force-pushed
the
feature/ts-tests
branch
from
71d3592
to
3fc6f6d
Compare
BREAKING CHANGE: `computeBidFee` accepts `startFee`, `increment` as options
davidyuk
force-pushed
the
feature/ts-tests
branch
from
3fc6f6d
to
4e2ece7
Compare
davidyuk
approved these changes
Jun 16, 2022
|
This pull request introduces 5 alerts when merging 4e2ece7 into 88d25af - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.